Recursive queries with many rows could throw an IndexOutOfBoundsException.

h2/src/main/org/h2/command/dml/Query.java

@@ -61,11 +61,12 @@ public abstract class Query extends Prepared {
      */
     protected boolean randomAccessResult;
 
+    private boolean noCache;
     private int lastLimit;
     private long lastEvaluated;
     private LocalResult lastResult;
     private Value[] lastParameters;
-    private boolean cacheableChecked, cacheable;
+    private boolean cacheableChecked;
 
     Query(Session session) {
         super(session);
@@ -218,13 +219,17 @@ public abstract class Query extends Prepared {
         return true;
     }
 
+    public void disableCache() {
+        this.noCache = true;
+    }
+
     private boolean sameResultAsLast(Session s, Value[] params, Value[] lastParams, long lastEval) {
         if (!cacheableChecked) {
             long max = getMaxDataModificationId();
-            cacheable = max != Long.MAX_VALUE;
+            noCache = max == Long.MAX_VALUE;
             cacheableChecked = true;
         }
-        if (!cacheable) {
+        if (noCache) {
             return false;
         }
         Database db = s.getDatabase();
@@ -269,7 +274,7 @@ public abstract class Query extends Prepared {
      */
     LocalResult query(int limit, ResultTarget target) {
         fireBeforeSelectTriggers();
-        if (!session.getDatabase().getOptimizeReuseResults()) {
+        if (noCache || !session.getDatabase().getOptimizeReuseResults()) {
             return queryWithoutCache(limit, target);
         }
         Value[] params = getParameterValues();
@@ -287,10 +292,11 @@ public abstract class Query extends Prepared {
         }
         lastParameters = params;
         closeLastResult();
-        lastResult = queryWithoutCache(limit, target);
+        LocalResult r = queryWithoutCache(limit, target);
+        lastResult = r;
         this.lastEvaluated = now;
         lastLimit = limit;
-        return lastResult;
+        return r;
     }
 
     private void closeLastResult() {

h2/src/main/org/h2/index/ViewIndex.java

@@ -157,7 +157,7 @@ public class ViewIndex extends BaseIndex {
 
     public Cursor find(Session session, SearchRow first, SearchRow last) {
         if (recursive) {
-            ResultInterface recResult = view.getRecursiveResult(session);
+            ResultInterface recResult = view.getRecursiveResult();
             if (recResult != null) {
                 recResult.reset();
                 return new ViewCursor(table, recResult);
@@ -174,6 +174,8 @@ public class ViewIndex extends BaseIndex {
                 throw DbException.get(ErrorCode.SYNTAX_ERROR_2, "recursive queries without UNION ALL");
             }
             Query left = union.getLeft();
+            // to ensure the last result isn't closed
+            left.disableCache();
             LocalResult r = left.query(0);
             LocalResult result = union.getEmptyResult();
             while (r.next()) {
@@ -181,7 +183,9 @@ public class ViewIndex extends BaseIndex {
             }
             Query right = union.getRight();
             r.reset();
-            view.setRecursiveResult(r, session);
+            view.setRecursiveResult(r);
+            // to ensure the last result isn't closed
+            right.disableCache();
             while (true) {
                 r = right.query(0);
                 if (r.getRowCount() == 0) {
@@ -191,8 +195,10 @@ public class ViewIndex extends BaseIndex {
                     result.addRow(r.currentRow());
                 }
                 r.reset();
-                view.setRecursiveResult(r, session);
+                view.setRecursiveResult(r);
             }
+            view.setRecursiveResult(null);
+            result.done();
             return new ViewCursor(table, result);
         }
         ArrayList<Parameter> paramList = query.getParameters();

h2/src/main/org/h2/table/TableView.java

@@ -444,12 +444,15 @@ public class TableView extends Table {
         return viewQuery.isEverything(ExpressionVisitor.DETERMINISTIC_VISITOR);
     }
 
-    public void setRecursiveResult(LocalResult value, Session session) {
-        this.recursiveResult = value.createShallowCopy(session);
+    public void setRecursiveResult(LocalResult value) {
+        if (recursiveResult != null) {
+            recursiveResult.close();
+        }
+        this.recursiveResult = value;
     }
 
-    public ResultInterface getRecursiveResult(Session session) {
-        return recursiveResult == null ? null : recursiveResult.createShallowCopy(session);
+    public ResultInterface getRecursiveResult() {
+        return recursiveResult;
     }
 
     public void setTableExpression(boolean tableExpression) {

h2/src/test/org/h2/test/db/TestRecursiveQueries.java

@@ -38,12 +38,15 @@ public class TestRecursiveQueries extends TestBase {
         stat = conn.createStatement();
         stat.execute("create table test(parent varchar(255), child varchar(255))");
         stat.execute("insert into test values('/', 'a'), ('a', 'b1'), ('a', 'b2'), ('a', 'c'), ('c', 'd1'), ('c', 'd2')");
-        // stat.execute("with recursive rec_test(depth, parent, child) as (" +
-        //        "select 0, parent, child from test where parent = '/' " +
-        //        "union all " +
-        //        "select depth+1, r.parent, r.child from test i join rec_test r " +
-        //        "on (i.parent = r.child) where depth<9 " +
-        //        ") select * from rec_test");
+
+        ResultSet rs = stat.executeQuery("with recursive rec_test(depth, parent, child) as (" +
+                "select 0, parent, child from test where parent = '/' " +
+                "union all " +
+                "select depth+1, r.parent, r.child from test i join rec_test r " +
+                "on (i.parent = r.child) where depth<9 " +
+                ") select count(*) from rec_test");
+        rs.next();
+        assertEquals(29524, rs.getInt(1));
         stat.execute("with recursive rec_test(depth, parent, child) as ( "+
                 "select 0, parent, child from test where parent = '/' "+
                 "union all "+