Improve error message when specifying incorrect scale/precision

h2/src/docsrc/textbase/_messages_en.prop

@@ -78,6 +78,7 @@
 90048=Unsupported database file version or invalid file header in file {0}
 90049=Encryption error in file {0}
 90050=Wrong password format, must be: file password <space> user password
+90051=Scale(${0}) must be <= precision({1})
 90052=Subquery is not a single column query
 90053=Scalar subquery contains more than one row
 90054=Invalid use of aggregate function {0}

h2/src/main/org/h2/api/ErrorCode.java

@@ -491,6 +491,16 @@ public class ErrorCode {
      */
     public static final int INVALID_VALUE_2 = 90008;
 
+    /**
+     * The error with code <code>90051</code> is thrown when
+     * trying to use a scale that is > precision.
+     * Example:
+     * <pre>
+     * CREATE TABLE TABLE1 ( FAIL NUMBER(6,24) );
+     * </pre>
+     */
+    public static final int INVALID_VALUE_SCALE_PRECISION = 90051;
+
     /**
      * The error with code <code>90009</code> is thrown when
      * trying to create a sequence with an invalid combination
@@ -1914,7 +1924,7 @@ public class ErrorCode {
     public static final int STEP_SIZE_MUST_NOT_BE_ZERO = 90142;
 
 
-    // next are 90051, 90056, 90110, 90122, 90143
+    // next are 90056, 90110, 90122, 90143
 
     private ErrorCode() {
         // utility class

h2/src/main/org/h2/command/Parser.java

@@ -129,8 +129,8 @@ import org.h2.table.IndexColumn;
 import org.h2.table.RangeTable;
 import org.h2.table.Table;
 import org.h2.table.TableFilter;
-import org.h2.table.TableView;
 import org.h2.table.TableFilter.TableFilterVisitor;
+import org.h2.table.TableView;
 import org.h2.util.MathUtils;
 import org.h2.util.New;
 import org.h2.util.StatementBuilder;
@@ -4068,9 +4068,8 @@ public class Parser {
         readIf("UNSIGNED");
         int type = dataType.type;
         if (scale > precision) {
-            throw DbException.get(ErrorCode.INVALID_VALUE_2,
-                    Integer.toString(scale), "scale (precision = " + precision +
-                            ")");
+            throw DbException.get(ErrorCode.INVALID_VALUE_SCALE_PRECISION,
+                    Integer.toString(scale), Long.toString(precision));
         }
         Column column = new Column(columnName, type, precision, scale,
                 displaySize);