提交 14ab748f authored 作者: Thomas Mueller's avatar Thomas Mueller

remove old TODOs

上级 f3c79d95
...@@ -20,8 +20,6 @@ public class CommandList extends Command { ...@@ -20,8 +20,6 @@ public class CommandList extends Command {
private final Command command; private final Command command;
private final String remaining; private final String remaining;
// TODO lock if possible!
public CommandList(Parser parser, String sql, Command c, String remaining) { public CommandList(Parser parser, String sql, Command c, String remaining) {
super(parser, sql); super(parser, sql);
this.command = c; this.command = c;
......
...@@ -1740,8 +1740,6 @@ public class Parser { ...@@ -1740,8 +1740,6 @@ public class Parser {
Expression condHigh = new Comparison(session, Comparison.BIGGER_EQUAL, high, r); Expression condHigh = new Comparison(session, Comparison.BIGGER_EQUAL, high, r);
r = new ConditionAndOr(ConditionAndOr.AND, condLow, condHigh); r = new ConditionAndOr(ConditionAndOr.AND, condLow, condHigh);
} else { } else {
// TODO parser: if we use a switch case, we don't need
// getCompareType any more
int compareType = getCompareType(currentTokenType); int compareType = getCompareType(currentTokenType);
if (compareType < 0) { if (compareType < 0) {
break; break;
...@@ -1910,8 +1908,6 @@ public class Parser { ...@@ -1910,8 +1908,6 @@ public class Parser {
private JavaFunction readJavaFunction(String name) throws SQLException { private JavaFunction readJavaFunction(String name) throws SQLException {
FunctionAlias functionAlias = database.findFunctionAlias(name); FunctionAlias functionAlias = database.findFunctionAlias(name);
if (functionAlias == null) { if (functionAlias == null) {
// TODO compatibility: support 'on the fly java functions' as HSQLDB
// ( CALL "java.lang.Math.sqrt"(2.0) )
throw Message.getSQLException(ErrorCode.FUNCTION_NOT_FOUND_1, name); throw Message.getSQLException(ErrorCode.FUNCTION_NOT_FOUND_1, name);
} }
Expression[] args; Expression[] args;
...@@ -2800,7 +2796,6 @@ public class Parser { ...@@ -2800,7 +2796,6 @@ public class Parser {
command[len] = ' '; command[len] = ' ';
int startLoop = 0; int startLoop = 0;
int lastType = 0; int lastType = 0;
// TODO optimization in parser: could remember the length of each token
for (int i = 0; i < len; i++) { for (int i = 0; i < len; i++) {
char c = command[i]; char c = command[i];
int type = 0; int type = 0;
......
Markdown 格式
0%
您添加了 0 到此讨论。请谨慎行事。
请先完成此评论的编辑!
注册 或者 后发表评论