提交 41b5225a authored 作者: Noel Grandin's avatar Noel Grandin

address review comments

上级 4867529d
......@@ -115,7 +115,8 @@ public class Select extends Query {
private int[] groupByCopies;
/**
* Whether this query contains aggregate functions.
* This flag is set when SELECT statement contains (non-window) aggregate
* functions, GROUP BY clause or HAVING clause.
*/
boolean isGroupQuery;
private boolean isGroupSortedQuery;
......@@ -176,7 +177,8 @@ public class Select extends Query {
}
/**
* Called if this query contains aggregate functions.
* Set when SELECT statement contains (non-window) aggregate functions,
* GROUP BY clause or HAVING clause.
*/
public void setGroupQuery() {
isGroupQuery = true;
......@@ -484,7 +486,7 @@ public class Select extends Query {
/**
* Update any aggregate expressions with the query stage.
* @param columnCount number of columns
* @param stage stage of query (window or normal)
* @param stage see STAGE_RESET/STAGE_GROUP/STAGE_WINDOW in DataAnalysisOperation
*/
void updateAgg(int columnCount, int stage) {
for (int i = 0; i < columnCount; i++) {
......
......@@ -31,7 +31,7 @@ public abstract class AbstractAggregate extends DataAnalysisOperation {
protected final boolean distinct;
/**
* FILTER condition for aggregate/window
* FILTER condition for aggregate
*/
protected Expression filterCondition;
......
......@@ -50,7 +50,7 @@ public abstract class DataAnalysisOperation extends Expression {
protected final Select select;
/**
* Window clause / OVER
* OVER clause
*/
protected Window over;
......@@ -426,7 +426,7 @@ public abstract class DataAnalysisOperation extends Expression {
ArrayList<Value[]> ordered, int rowIdColumn);
/**
* Used to create SQL for the OVER part of the command.
* Used to create SQL for the OVER and FILTER clauses.
*
* @param builder string builder
* @return the builder object
......
......@@ -729,7 +729,7 @@ public class TransactionStore {
VersionedValue existingValue, VersionedValue restoredValue);
}
private static RollbackListener ROLLBACK_LISTENER_NONE = new RollbackListener() {
private static final RollbackListener ROLLBACK_LISTENER_NONE = new RollbackListener() {
@Override
public void onRollback(MVMap<Object, VersionedValue> map, Object key,
VersionedValue existingValue, VersionedValue restoredValue) {
......
Markdown 格式
0%
您添加了 0 到此讨论。请谨慎行事。
请先完成此评论的编辑!
注册 或者 后发表评论