Improved error reporting / better tests

h2/src/docsrc/html/changelog.html

@@ -18,7 +18,8 @@ Change Log
 <h1>Change Log</h1>
 
 <h2>Next Version (unreleased)</h2>
-<ul><li>When using the PageStore, opening a database failed in some cases with a NullPointerException
+<ul><li>Large result sets now always create temporary tables instead of temporary files.
+</li><li>When using the PageStore, opening a database failed in some cases with a NullPointerException
     if temporary tables were used (explicitly, or implicitly when using large result sets).
 </li><li>If a database file in the PageStore file format exists, this file and this mode
     is now used, even if the database URL does not contain "MV_STORE=FALSE".

h2/src/main/org/h2/engine/Database.java

@@ -675,8 +675,10 @@ public class Database implements DataHandler {
             }
             traceSystem = new TraceSystem(null);
             trace = traceSystem.getTrace(Trace.DATABASE);
+            if (dbSettings.mvStore) {
                 getPageStore();
             }
+        }
         systemUser = new User(this, 0, SYSTEM_USER_NAME, true);
         mainSchema = new Schema(this, 0, Constants.SCHEMA_MAIN, systemUser, true);
         infoSchema = new Schema(this, -1, "INFORMATION_SCHEMA", systemUser, true);

h2/src/main/org/h2/mvstore/MVStore.java

@@ -104,6 +104,7 @@ MVStore:
 - Support SortedMap for MVMap
 - compact: copy whole pages (without having to open all maps)
 - maybe change the length code to have lower gaps
+- test with very low limits (such as: short chunks, small pages)
 
 */
 

h2/src/main/org/h2/store/LobStorageMap.java

@@ -225,6 +225,9 @@ public class LobStorageMap implements LobStorageInterface {
             throws IOException {
         init();
         Object[] value = lobMap.get(lob.getLobId());
+        if (value == null) {
+            throw DbException.throwInternalError("Lob not found: " + lob.getLobId());
+        }
         byte[] streamStoreId = (byte[]) value[0];
         return streamStore.get(streamStoreId);
     }

h2/src/test/org/h2/test/TestAll.java

@@ -389,7 +389,7 @@ java org.h2.test.TestAll timer
         ; // TEST
 //        System.setProperty("h2.maxMemoryRows", "2");
         
-        System.setProperty("h2.maxMemoryRows", "100");
+        System.setProperty("h2.maxMemoryRows", "10");
 //        System.setProperty("h2.maxMemoryRows", "1000");
 //        System.setProperty("h2.maxMemoryRows", "2");