Fix bug in calculating default MIN and MAX values for SEQUENCE

h2/src/docsrc/html/changelog.html

@@ -20,6 +20,7 @@ Change Log
 <h2>Next Version (unreleased)</h2>
 <ul><li>Storing LOBs in separate files (outside of the database) is no longer supported for new databases.
 </li><li>Lucene 2 is no longer supported.
+</li><li>Fix bug in calculating default MIN and MAX values for SEQUENCE
 </li></ul>
 
 <h2>Version 1.3.175 (2014-01-18)</h2>

h2/src/main/org/h2/schema/Sequence.java

@@ -66,8 +66,8 @@ public class Sequence extends SchemaObjectBase {
             Long minValue, Long maxValue, boolean cycle, boolean belongsToTable) {
         initSchemaObjectBase(schema, id, name, Trace.SEQUENCE);
         this.increment = increment != null ? increment : 1;
-        this.minValue = minValue != null ? minValue : getDefaultMinValue(this.increment);
-        this.maxValue = maxValue != null ? maxValue : getDefaultMaxValue(this.increment);
+        this.minValue = minValue != null ? minValue : getDefaultMinValue(startValue, this.increment);
+        this.maxValue = maxValue != null ? maxValue : getDefaultMaxValue(startValue, this.increment);
         this.value = startValue != null ? startValue : getDefaultStartValue(this.increment);
         this.valueWithMargin = value;
         this.cacheSize = cacheSize != null ? Math.max(1, cacheSize) : DEFAULT_CACHE_SIZE;
@@ -136,12 +136,20 @@ public class Sequence extends SchemaObjectBase {
                 BigInteger.valueOf(maxValue).subtract(BigInteger.valueOf(minValue))) < 0;
     }
 
-    private static long getDefaultMinValue(long increment) {
-        return increment >= 0 ? 1 : Long.MIN_VALUE;
+    private static long getDefaultMinValue(Long startValue, long increment) {
+        long v = increment >= 0 ? 1 : Long.MIN_VALUE;
+        if (startValue != null && increment >= 0 && startValue < v) {
+            v = startValue;
+        }
+        return v;
     }
 
-    private static long getDefaultMaxValue(long increment) {
-        return increment >= 0 ? Long.MAX_VALUE : -1;
+    private static long getDefaultMaxValue(Long startValue, long increment) {
+        long v = increment >= 0 ? Long.MAX_VALUE : -1;
+        if (startValue != null && increment < 0 && startValue > v) {
+            v = startValue;
+        }
+        return v;
     }
 
     private long getDefaultStartValue(long increment) {
@@ -192,10 +200,10 @@ public class Sequence extends SchemaObjectBase {
         if (increment != 1) {
             buff.append(" INCREMENT BY ").append(increment);
         }
-        if (minValue != getDefaultMinValue(increment)) {
+        if (minValue != getDefaultMinValue(value, increment)) {
             buff.append(" MINVALUE ").append(minValue);
         }
-        if (maxValue != getDefaultMaxValue(increment)) {
+        if (maxValue != getDefaultMaxValue(value, increment)) {
             buff.append(" MAXVALUE ").append(maxValue);
         }
         if (cycle) {

h2/src/test/org/h2/test/db/TestSequence.java

@@ -41,6 +41,7 @@ public class TestSequence extends TestBase {
         testCreateWithMaxValue();
         testCreationErrors();
         testCreateSql();
+        testDefaultMinMax();
         deleteDb("sequence");
     }
 
@@ -252,6 +253,16 @@ public class TestSequence extends TestBase {
         conn.close();
     }
 
+    private void testDefaultMinMax() throws SQLException {
+        // test that we calculate default MIN and MAX values correctly
+        deleteDb("sequence");
+        Connection conn = getConnection("sequence");
+        Statement stat = conn.createStatement();
+        stat.execute("create sequence a START WITH -7320917853639540658");
+        stat.execute("create sequence b START WITH 7320917853639540658 INCREMENT -1");
+        conn.close();
+    }
+    
     private void testTwo() throws SQLException {
         deleteDb("sequence");
         Connection conn = getConnection("sequence");