提交 671c7ee3 authored 作者: Evgenij Ryazanov's avatar Evgenij Ryazanov

Do not use Double and long in ValueFloat and collapse NaNs into one

上级 c62889dc
...@@ -34,6 +34,7 @@ public class ValueFloat extends Value { ...@@ -34,6 +34,7 @@ public class ValueFloat extends Value {
private static final ValueFloat ZERO = new ValueFloat(0.0F); private static final ValueFloat ZERO = new ValueFloat(0.0F);
private static final ValueFloat ONE = new ValueFloat(1.0F); private static final ValueFloat ONE = new ValueFloat(1.0F);
private static final ValueFloat NAN = new ValueFloat(Float.NaN);
private final float value; private final float value;
...@@ -88,7 +89,7 @@ public class ValueFloat extends Value { ...@@ -88,7 +89,7 @@ public class ValueFloat extends Value {
return "POWER(0, -1)"; return "POWER(0, -1)";
} else if (value == Float.NEGATIVE_INFINITY) { } else if (value == Float.NEGATIVE_INFINITY) {
return "(-POWER(0, -1))"; return "(-POWER(0, -1))";
} else if (Double.isNaN(value)) { } else if (Float.isNaN(value)) {
// NaN // NaN
return "SQRT(-1)"; return "SQRT(-1)";
} }
...@@ -133,8 +134,11 @@ public class ValueFloat extends Value { ...@@ -133,8 +134,11 @@ public class ValueFloat extends Value {
@Override @Override
public int hashCode() { public int hashCode() {
long hash = Float.floatToIntBits(value); /*
return (int) (hash ^ (hash >> 32)); * NaNs are normalized in get() method, so it's safe to use
* floatToRawIntBits() instead of floatToIntBits() here.
*/
return Float.floatToRawIntBits(value);
} }
@Override @Override
...@@ -160,6 +164,8 @@ public class ValueFloat extends Value { ...@@ -160,6 +164,8 @@ public class ValueFloat extends Value {
} else if (d == 0.0F) { } else if (d == 0.0F) {
// -0.0 == 0.0, and we want to return 0.0 for both // -0.0 == 0.0, and we want to return 0.0 for both
return ZERO; return ZERO;
} else if (Float.isNaN(d)) {
return NAN;
} }
return (ValueFloat) Value.cache(new ValueFloat(d)); return (ValueFloat) Value.cache(new ValueFloat(d));
} }
......
Markdown 格式
0%
您添加了 0 到此讨论。请谨慎行事。
请先完成此评论的编辑!
注册 或者 后发表评论