Remove unused code

h2/src/main/org/h2/index/BtreeLeaf.java

@@ -7,10 +7,8 @@
 package org.h2.index;
 
 import java.sql.SQLException;
-
 import org.h2.constant.ErrorCode;
 import org.h2.constant.SysProperties;
-import org.h2.engine.Constants;
 import org.h2.engine.Session;
 import org.h2.message.Message;
 import org.h2.result.Row;
@@ -90,11 +88,6 @@ public class BtreeLeaf extends BtreePage {
 
     SearchRow remove(Session session, Row oldRow) throws SQLException {
         int l = 0, r = pageData.size();
-        if (r == 0) {
-            if (!Constants.ALLOW_EMPTY_BTREE_PAGES && !root) {
-                Message.throwInternalError("Empty btree page");
-            }
-        }
         while (l < r) {
             int i = (l + r) >>> 1;
             SearchRow row = pageData.get(i);
@@ -148,9 +141,6 @@ public class BtreeLeaf extends BtreePage {
 
     boolean findFirst(BtreeCursor cursor, SearchRow compare, boolean bigger) throws SQLException {
         int l = 0, r = pageData.size();
-        if (r == 0 && !Constants.ALLOW_EMPTY_BTREE_PAGES && !root) {
-            Message.throwInternalError("Empty btree page");
-        }
         while (l < r) {
             int i = (l + r) >>> 1;
             SearchRow row = pageData.get(i);
@@ -196,9 +186,6 @@ public class BtreeLeaf extends BtreePage {
 
     void first(BtreeCursor cursor) throws SQLException {
         if (pageData.size() == 0) {
-            if (!Constants.ALLOW_EMPTY_BTREE_PAGES && !root) {
-                Message.throwInternalError("Empty btree page");
-            }
             nextUpper(cursor);
             return;
         }
@@ -210,9 +197,6 @@ public class BtreeLeaf extends BtreePage {
     void last(BtreeCursor cursor) throws SQLException {
         int last = pageData.size() - 1;
         if (last < 0) {
-            if (!Constants.ALLOW_EMPTY_BTREE_PAGES && !root) {
-                Message.throwInternalError("Empty btree page");
-            }
             previousUpper(cursor);
             return;
         }
@@ -298,9 +282,6 @@ public class BtreeLeaf extends BtreePage {
 
     SearchRow getFirst(Session session) {
         if (pageData.size() == 0) {
-            if (!Constants.ALLOW_EMPTY_BTREE_PAGES && !root) {
-                Message.throwInternalError("Empty btree page");
-            }
             return null;
         }
         return pageData.get(0);

h2/src/main/org/h2/index/BtreeNode.java

@@ -7,9 +7,7 @@
 package org.h2.index;
 
 import java.sql.SQLException;
-
 import org.h2.constant.SysProperties;
-import org.h2.engine.Constants;
 import org.h2.engine.Session;
 import org.h2.message.Message;
 import org.h2.result.Row;
@@ -75,9 +73,6 @@ public class BtreeNode extends BtreePage {
 
     int add(Row newRow, Session session) throws SQLException {
         int l = 0, r = pageData.size();
-        if (!Constants.ALLOW_EMPTY_BTREE_PAGES && !root && pageChildren.size() == 0) {
-            Message.throwInternalError("Empty btree page");
-        }
         while (l < r) {
             int i = (l + r) >>> 1;
             SearchRow row = getData(i);
@@ -125,9 +120,6 @@ public class BtreeNode extends BtreePage {
 
     SearchRow remove(Session session, Row oldRow) throws SQLException {
         int l = 0, r = pageData.size();
-        if (!Constants.ALLOW_EMPTY_BTREE_PAGES && !root && pageChildren.size() == 0) {
-            Message.throwInternalError("Empty btree page");
-        }
         int comp = 0;
         while (l < r) {
             int i = (l + r) >>> 1;
@@ -221,9 +213,6 @@ public class BtreeNode extends BtreePage {
 
     boolean findFirst(BtreeCursor cursor, SearchRow compare, boolean bigger) throws SQLException {
         int l = 0, r = pageData.size();
-        if (!Constants.ALLOW_EMPTY_BTREE_PAGES && !root && pageChildren.size() == 0) {
-            Message.throwInternalError("Empty btree page");
-        }
         while (l < r) {
             int i = (l + r) >>> 1;
             SearchRow row = getData(i);
@@ -319,9 +308,6 @@ public class BtreeNode extends BtreePage {
 
     void first(BtreeCursor cursor) throws SQLException {
         if (pageChildren.size() == 0) {
-            if (!Constants.ALLOW_EMPTY_BTREE_PAGES && !root) {
-                Message.throwInternalError("Empty btree page");
-            }
             nextUpper(cursor);
             return;
         }
@@ -333,9 +319,6 @@ public class BtreeNode extends BtreePage {
     void last(BtreeCursor cursor) throws SQLException {
         int last = pageChildren.size() - 1;
         if (last < 0) {
-            if (!Constants.ALLOW_EMPTY_BTREE_PAGES && !root) {
-                Message.throwInternalError("Empty btree page");
-            }
             previousUpper(cursor);
             return;
         }

h2/src/main/org/h2/index/HashIndex.java

@@ -100,7 +100,7 @@ public class HashIndex extends BaseIndex {
     public Cursor find(Session session, SearchRow first, SearchRow last) throws SQLException {
         if (first == null || last == null) {
             // TODO hash index: should additionally check if values are the same
-            Message.throwInternalError();
+            throw Message.throwInternalError();
         }
         Row result;
         if (intMap != null) {

h2/src/main/org/h2/index/TreeIndex.java

@@ -139,7 +139,7 @@ public class TreeIndex extends BaseIndex {
     public void remove(Session session, Row row) throws SQLException {
         TreeNode x = findFirstNode(row, true);
         if (x == null) {
-            Message.throwInternalError("not found!");
+            throw Message.throwInternalError("not found!");
         }
         TreeNode n;
         if (x.left == null) {