MVStore: lock rows before update/delete

h2/src/main/org/h2/command/dml/Delete.java

@@ -84,7 +84,12 @@ public class Delete extends Prepared {
                         done = table.fireBeforeRow(session, row, null);
                     }
                     if (!done) {
-                        rows.add(row);
+                        if (table.isMVStore()) {
+                            done = table.lockRow(session, row) == null;
+                        }
+                        if (!done) {
+                            rows.add(row);
+                        }
                     }
                     count++;
                     if (limitRows >= 0 && count >= limitRows) {

h2/src/main/org/h2/command/dml/Update.java

@@ -164,8 +164,13 @@ public class Update extends Prepared {
                         done = table.fireBeforeRow(session, oldRow, newRow);
                     }
                     if (!done) {
-                        rows.add(oldRow);
-                        rows.add(newRow);
+                        if (table.isMVStore()) {
+                            done = table.lockRow(session, oldRow) == null;
+                        }
+                        if (!done) {
+                            rows.add(oldRow);
+                            rows.add(newRow);
+                        }
                     }
                     count++;
                 }

h2/src/main/org/h2/mvstore/db/MVPrimaryIndex.java

@@ -209,15 +209,26 @@ public class MVPrimaryIndex extends BaseIndex {
         }
     }
 
-    public void lockRows(Session session, Iterable<Row> rowsForUpdate) {
+    void lockRows(Session session, Iterable<Row> rowsForUpdate) {
         TransactionMap<Value, Value> map = getMap(session);
         for (Row row : rowsForUpdate) {
             long key = row.getKey();
-            try {
-                map.lock(ValueLong.get(key));
-            } catch (IllegalStateException ex) {
-                throw mvTable.convertException(ex);
-            }
+            lockRow(map, key);
+        }
+    }
+
+    Row lockRow(Session session, Row row) {
+        TransactionMap<Value, Value> map = getMap(session);
+        long key = row.getKey();
+        ValueArray array = (ValueArray) lockRow(map, key);
+        return array == null ? null : getRow(session, key, array);
+    }
+
+    private Value lockRow(TransactionMap<Value, Value> map, long key) {
+        try {
+            return map.lock(ValueLong.get(key));
+        } catch (IllegalStateException ex) {
+            throw mvTable.convertException(ex);
         }
     }
 
@@ -259,7 +270,10 @@ public class MVPrimaryIndex extends BaseIndex {
             throw DbException.get(ErrorCode.ROW_NOT_FOUND_IN_PRIMARY_INDEX,
                     getSQL(), String.valueOf(key));
         }
-        ValueArray array = (ValueArray) v;
+        return getRow(session, key, (ValueArray) v);
+    }
+
+    public Row getRow(Session session, long key, ValueArray array) {
         Row row = session.createRow(array.getList(), 0);
         row.setKey(key);
         return row;

h2/src/main/org/h2/mvstore/db/MVTable.java

@@ -738,6 +738,11 @@ public class MVTable extends TableBase {
         primaryIndex.lockRows(session, rowsForUpdate);
     }
 
+    @Override
+    public Row lockRow(Session session, Row row) {
+        return primaryIndex.lockRow(session, row);
+    }
+
     private void analyzeIfRequired(Session session) {
         if (changesUntilAnalyze != null) {
             if (changesUntilAnalyze.decrementAndGet() == 0) {

h2/src/main/org/h2/mvstore/tx/TxDecisionMaker.java

@@ -206,11 +206,22 @@ abstract class TxDecisionMaker extends MVMap.DecisionMaker<VersionedValue> {
             super(mapId, key, null, transaction);
         }
 
+        @Override
+        public MVMap.Decision decide(VersionedValue existingValue, VersionedValue providedValue) {
+            MVMap.Decision decision = super.decide(existingValue, providedValue);
+            if (existingValue == null) {
+                assert decision == MVMap.Decision.PUT;
+                decision = setDecision(MVMap.Decision.REMOVE);
+            }
+            return decision;
+        }
+
         @SuppressWarnings("unchecked")
         @Override
         public VersionedValue selectValue(VersionedValue existingValue, VersionedValue providedValue) {
-            assert existingValue != null;   // otherwise, what's there to lock?
-            return VersionedValue.getInstance(undoKey, existingValue.value, existingValue.getCommittedValue());
+            return VersionedValue.getInstance(undoKey,
+                    existingValue == null ? null : existingValue.value,
+                    existingValue == null ? null : existingValue.getCommittedValue());
         }
     }
 }

h2/src/main/org/h2/table/Table.java

@@ -184,14 +184,26 @@ public abstract class Table extends SchemaObjectBase {
      */
     public void lockRows(Session session, Iterable<Row> rowsForUpdate) {
         for (Row row : rowsForUpdate) {
-            Row newRow = row.getCopy();
-            removeRow(session, row);
-            session.log(this, UndoLogRecord.DELETE, row);
-            addRow(session, newRow);
-            session.log(this, UndoLogRecord.INSERT, newRow);
+            lockRow(session, row);
         }
     }
 
+    /**
+     * Locks row, preventing any updated to it, except from the session specified.
+     *
+     * @param session the session
+     * @param row to lock
+     * @return locked row, or null if row does not exist anymore
+     */
+    public Row lockRow(Session session, Row row) {
+        Row newRow = row.getCopy();
+        removeRow(session, row);
+        session.log(this, UndoLogRecord.DELETE, row);
+        addRow(session, newRow);
+        session.log(this, UndoLogRecord.INSERT, newRow);
+        return row;
+    }
+
     /**
      * Remove all rows from the table and indexes.
      *