Merge pull request #1752 from katzyn/condition_in_select

Fix ConditionInSelect used as JOIN ON condition

h2/src/docsrc/html/changelog.html

@@ -21,12 +21,14 @@ Change Log
 
 <h2>Next Version (unreleased)</h2>
 <ul>
-<li>-
+<li>Issue #1750: JOIN t ON t.col IN (SELECT ...) throws AssertionError
 </li>
 </ul>
 
 <h2>Version 1.4.198 (2019-02-22)</h2>
 <ul>
+<li>Issue #1746: Infinite loop in TestConcurrent.testConcurrentChangeAndGetVersion()
+</li>
 <li>Issue #1739: Table and view names not case sensitive when using DATABASE_TO_UPPER=FALSE
 </li>
 <li>Issue #848: H2 PostgreSQL Compatibility Mode: lowercase metadata

h2/src/main/org/h2/expression/condition/ConditionInSelect.java

@@ -41,6 +41,11 @@ public class ConditionInSelect extends Condition {
         this.database = database;
         this.left = left;
         this.query = query;
+        /*
+         * Need to do it now because other methods may be invoked in different
+         * order.
+         */
+        query.setRandomAccessResult(true);
         this.all = all;
         this.compareType = compareType;
     }
@@ -140,7 +145,6 @@ public class ConditionInSelect extends Condition {
     @Override
     public Expression optimize(Session session) {
         left = left.optimize(session);
-        query.setRandomAccessResult(true);
         session.optimizeQueryExpression(query);
         // Can not optimize: the data may change
         return this;

h2/src/test/org/h2/test/scripts/dml/select.sql

@@ -654,3 +654,14 @@ SELECT _ROWID_ S1, TEST._ROWID_ S2, PUBLIC.TEST._ROWID_ S3, SCRIPT.PUBLIC.TEST._
 
 DROP TABLE TEST;
 > ok
+
+CREATE TABLE TEST(ID BIGINT PRIMARY KEY);
+> ok
+
+SELECT X.ID FROM TEST X JOIN TEST Y ON Y.ID IN (SELECT 1);
+> ID
+> --
+> rows: 0
+
+DROP TABLE TEST;
+> ok