Each session threw an invisible exception when garbage collected.

h2/src/docsrc/html/changelog.html

@@ -18,7 +18,9 @@ Change Log
 <h1>Change Log</h1>
 
 <h2>Next Version (unreleased)</h2>
-<ul><li>New meta data column INFORMATION_SCHEMA.TABLES.LAST_MODIFICATION to get
+<ul><li>Each session threw an invisible exception when garbage collected.
+</li><li>Foreign key constraints referring to a quoted column did not work.
+</li><li>New meta data column INFORMATION_SCHEMA.TABLES.LAST_MODIFICATION to get
     the table modification counter.
 </li><li>Shell: line comments didn't work correctly.
 </li><li>H2 Console: Columns are now listed for up to 500 tables instead of 100.

h2/src/main/org/h2/engine/Session.java

@@ -42,9 +42,9 @@ import org.h2.value.ValueLong;
 import org.h2.value.ValueNull;
 
 /**
- * A session represents a database connection. When using the server mode, this
- * object resides on the server side and communicates with a RemoteSession on
- * the client side.
+ * A session represents an embedded database connection. When using the server
+ * mode, this object resides on the server side and communicates with a
+ * SessionRemote object on the client side.
  */
 public class Session implements SessionInterface {
 
@@ -92,10 +92,6 @@ public class Session implements SessionInterface {
     private Table waitForLock;
     private int modificationId;
 
-    public Session() {
-        // nothing to do
-    }
-
     Session(Database database, User user, int id) {
         this.database = database;
         this.undoLog = new UndoLog(this);
@@ -305,10 +301,6 @@ public class Session implements SessionInterface {
         this.lockTimeout = lockTimeout;
     }
 
-    public SessionInterface createSession(ConnectionInfo ci) throws SQLException {
-        return Engine.getInstance().getSession(ci);
-    }
-
     public CommandInterface prepareCommand(String sql, int fetchSize) throws SQLException {
         return prepareLocal(sql);
     }

h2/src/main/org/h2/engine/SessionFactory.java

+/*
+ * Copyright 2004-2008 H2 Group. Multiple-Licensed under the H2 License,
+ * Version 1.0, and under the Eclipse Public License, Version 1.0
+ * (http://h2database.com/html/license.html).
+ * Initial Developer: H2 Group
+ */
+package org.h2.engine;
+
+import java.sql.SQLException;
+
+/**
+ * A class that implements this interface can create new database sessions.
+ */
+public interface SessionFactory {
+
+    /**
+     * Create a new session.
+     *
+     * @param ci the connection parameters
+     * @return the new session
+     */
+    SessionInterface createSession(ConnectionInfo ci) throws SQLException;
+
+}

h2/src/main/org/h2/engine/SessionFactoryEmbedded.java

+/*
+ * Copyright 2004-2008 H2 Group. Multiple-Licensed under the H2 License,
+ * Version 1.0, and under the Eclipse Public License, Version 1.0
+ * (http://h2database.com/html/license.html).
+ * Initial Developer: H2 Group
+ */
+package org.h2.engine;
+
+import java.sql.SQLException;
+
+/**
+ * A factory for embedded database sessions.
+ */
+public class SessionFactoryEmbedded implements SessionFactory {
+
+    public SessionInterface createSession(ConnectionInfo ci) throws SQLException {
+        return Engine.getInstance().getSession(ci);
+    }
+
+}

h2/src/main/org/h2/engine/SessionInterface.java

@@ -45,14 +45,6 @@ public interface SessionInterface {
      */
     boolean isClosed();
 
-    /**
-     * Open a new session.
-     *
-     * @param ci the connection parameters
-     * @return the new session
-     */
-    SessionInterface createSession(ConnectionInfo ci) throws SQLException;
-
     /**
      * Get the number of disk operations before power failure is simulated.
      * This is used for testing. If not set, 0 is returned

h2/src/main/org/h2/engine/SessionRemote.java

@@ -41,7 +41,7 @@ import org.h2.value.ValueString;
  * The client side part of a session when using the server mode. This object
  * communicates with a Session on the server side.
  */
-public class SessionRemote implements SessionInterface, DataHandler {
+public class SessionRemote implements SessionInterface, SessionFactory, DataHandler {
 
     public static final int SESSION_PREPARE = 0;
     public static final int SESSION_CLOSE = 1;
@@ -244,11 +244,11 @@ public class SessionRemote implements SessionInterface, DataHandler {
                 backup = (ConnectionInfo) ci.clone();
                 connectionInfo = (ConnectionInfo) ci.clone();
             }
-            SessionInterface si = (SessionInterface) ClassUtils.loadSystemClass("org.h2.engine.Session").newInstance();
+            SessionFactory sf = (SessionFactory) ClassUtils.loadSystemClass("org.h2.engine.SessionFactoryEmbedded").newInstance();
             if (openNew) {
                 ci.setProperty("OPEN_NEW", "true");
             }
-            return si.createSession(ci);
+            return sf.createSession(ci);
         } catch (SQLException e) {
             int errorCode = e.getErrorCode();
             if (errorCode == ErrorCode.DATABASE_ALREADY_OPEN_1) {