MVStore: creating secondary indexes on large tables results in missing rows in the index.

h2/src/docsrc/html/changelog.html

@@ -18,7 +18,9 @@ Change Log
 <h1>Change Log</h1>
 
 <h2>Next Version (unreleased)</h2>
-<ul><li>Metadata: the password of linked tables is now only visible for admin users.
+<ul><li>MVStore: creating secondary indexes on large tables 
+    results in missing rows in the index.
+</li><li>Metadata: the password of linked tables is now only visible for admin users.
 </li><li>For Windows, database URLs of the form "jdbc:h2:/test" where considered
     relative and did not work unless the system property "h2.implicitRelativePath" was used.
 </li><li>Follow JDBC specification on Procedures MetaData, use P0 as

h2/src/main/org/h2/mvstore/db/MVSecondaryIndex.java

@@ -151,9 +151,6 @@ public class MVSecondaryIndex extends BaseIndex implements MVIndex {
                 } else {
                     Value nextValue = it.next();
                     sources.remove(s);
-                    if (sources.size() == 0) {
-                        break;
-                    }
                     s.value = nextValue;
                     sources.add(s);
                 }

h2/src/test/org/h2/test/store/TestMVTableEngine.java

@@ -49,6 +49,7 @@ public class TestMVTableEngine extends TestBase {
 
     @Override
     public void test() throws Exception {
+        testSecondaryIndex();
         testGarbageCollectionForLOB();
         testSpatial();
         testCount();
@@ -76,6 +77,28 @@ public class TestMVTableEngine extends TestBase {
         testSimple();
     }
     
+    private void testSecondaryIndex() throws SQLException {
+        FileUtils.deleteRecursive(getBaseDir(), true);
+        Connection conn;
+        Statement stat;
+        String url = "mvstore;MV_STORE=TRUE";
+        url = getURL(url, true);
+        conn = getConnection(url);
+        stat = conn.createStatement();
+        stat.execute("create table test(id int)");
+        int size = 8 * 1024;
+        stat.execute("insert into test select mod(x * 111, " + size + ") " + 
+                "from system_range(1, " + size + ")");
+        stat.execute("create index on test(id)");
+        ResultSet rs = stat.executeQuery(
+                "select count(*) from test inner join " +
+                "system_range(1, " + size + ") where " + 
+                "id = mod(x * 111, " + size + ")");
+        rs.next();
+        assertEquals(size, rs.getInt(1));
+        conn.close();
+    }
+
     private void testGarbageCollectionForLOB() throws SQLException {
         FileUtils.deleteRecursive(getBaseDir(), true);
         Connection conn;