Skip to content

H
h2database
提交 eff9d795 authored 作者: Thomas Mueller's avatar Thomas Mueller
浏览文件
操作

CSV reading is now faster.

上级 f733494f
隐藏空白字符变更
内嵌 并排
正在显示 包含 178 行增加 和 142 行删除
h2/src/docsrc/html/changelog.html
浏览文件 @ eff9d795
...@@ -18,7 +18,8 @@ Change Log ...@@ -18,7 +18,8 @@ Change Log
<h1>Change Log</h1> <h1>Change Log</h1>
<h2>Next Version (unreleased)</h2> <h2>Next Version (unreleased)</h2>
<ul><li>- <ul><li>SimpleResultSet.newInstance(SimpleRowSource rs) did not work.
</li><li>CSV reading is now faster.
</li></ul> </li></ul>
<h2>Version 1.1.116 (2009-07-18)</h2> <h2>Version 1.1.116 (2009-07-18)</h2>
......
h2/src/main/org/h2/bnf/Bnf.java
浏览文件 @ eff9d795
...@@ -6,7 +6,6 @@ ...@@ -6,7 +6,6 @@
*/ */
package org.h2.bnf; package org.h2.bnf;
import java.io.BufferedReader;
import java.io.ByteArrayInputStream; import java.io.ByteArrayInputStream;
import java.io.IOException; import java.io.IOException;
import java.io.InputStreamReader; import java.io.InputStreamReader;
...@@ -81,7 +80,6 @@ public class Bnf { ...@@ -81,7 +80,6 @@ public class Bnf {
} }
private void parse(Reader csv) throws SQLException, IOException { private void parse(Reader csv) throws SQLException, IOException {
csv = new BufferedReader(csv);
Rule functions = null; Rule functions = null;
statements = New.arrayList(); statements = New.arrayList();
ResultSet rs = Csv.getInstance().read(csv, null); ResultSet rs = Csv.getInstance().read(csv, null);
......
h2/src/main/org/h2/table/MetaTable.java
浏览文件 @ eff9d795
...@@ -6,7 +6,6 @@ ...@@ -6,7 +6,6 @@
*/ */
package org.h2.table; package org.h2.table;
import java.io.BufferedReader;
import java.io.ByteArrayInputStream; import java.io.ByteArrayInputStream;
import java.io.IOException; import java.io.IOException;
import java.io.InputStreamReader; import java.io.InputStreamReader;
...@@ -920,7 +919,7 @@ public class MetaTable extends Table { ...@@ -920,7 +919,7 @@ public class MetaTable extends Table {
String resource = "/org/h2/res/help.csv"; String resource = "/org/h2/res/help.csv";
try { try {
byte[] data = Resources.get(resource); byte[] data = Resources.get(resource);
Reader reader = new BufferedReader(new InputStreamReader(new ByteArrayInputStream(data))); Reader reader = new InputStreamReader(new ByteArrayInputStream(data));
ResultSet rs = Csv.getInstance().read(reader, null); ResultSet rs = Csv.getInstance().read(reader, null);
for (int i = 0; rs.next(); i++) { for (int i = 0; rs.next(); i++) {
add(rows, new String[] { add(rows, new String[] {
......
h2/src/main/org/h2/tools/Csv.java
浏览文件 @ eff9d795
...@@ -8,7 +8,6 @@ package org.h2.tools; ...@@ -8,7 +8,6 @@ package org.h2.tools;
import java.io.BufferedInputStream; import java.io.BufferedInputStream;
import java.io.BufferedOutputStream; import java.io.BufferedOutputStream;
import java.io.BufferedReader;
import java.io.BufferedWriter; import java.io.BufferedWriter;
import java.io.IOException; import java.io.IOException;
import java.io.InputStream; import java.io.InputStream;
...@@ -25,12 +24,12 @@ import java.sql.Statement; ...@@ -25,12 +24,12 @@ import java.sql.Statement;
import java.sql.Types; import java.sql.Types;
import java.util.ArrayList; import java.util.ArrayList;
import org.h2.constant.SysProperties; import org.h2.constant.SysProperties;
import org.h2.engine.Constants;
import org.h2.message.Message; import org.h2.message.Message;
import org.h2.util.FileUtils; import org.h2.util.FileUtils;
import org.h2.util.IOUtils; import org.h2.util.IOUtils;
import org.h2.util.JdbcUtils; import org.h2.util.JdbcUtils;
import org.h2.util.New; import org.h2.util.New;
import org.h2.util.StringCache;
/** /**
* A facility to read from and write to CSV (comma separated values) files. * A facility to read from and write to CSV (comma separated values) files.
...@@ -40,7 +39,6 @@ import org.h2.util.StringCache; ...@@ -40,7 +39,6 @@ import org.h2.util.StringCache;
public class Csv implements SimpleRowSource { public class Csv implements SimpleRowSource {
private String streamCharset = SysProperties.FILE_ENCODING; private String streamCharset = SysProperties.FILE_ENCODING;
private int bufferSize = 8 * 1024;
private String[] columnNames; private String[] columnNames;
private char fieldSeparatorRead = ','; private char fieldSeparatorRead = ',';
private char commentLineStart = '#'; private char commentLineStart = '#';
...@@ -52,8 +50,11 @@ public class Csv implements SimpleRowSource { ...@@ -52,8 +50,11 @@ public class Csv implements SimpleRowSource {
private String nullString = ""; private String nullString = "";
private String fileName; private String fileName;
private Reader input; private Reader input;
private char[] inputBuffer;
private int inputBufferPos;
private int inputBufferStart = -1;
private int inputBufferEnd;
private Writer output; private Writer output;
private int back;
private boolean endOfLine, endOfFile; private boolean endOfLine, endOfFile;
private Csv() { private Csv() {
...@@ -229,7 +230,7 @@ public class Csv implements SimpleRowSource { ...@@ -229,7 +230,7 @@ public class Csv implements SimpleRowSource {
if (output == null) { if (output == null) {
try { try {
OutputStream out = FileUtils.openFileOutputStream(fileName, false); OutputStream out = FileUtils.openFileOutputStream(fileName, false);
out = new BufferedOutputStream(out, bufferSize); out = new BufferedOutputStream(out, Constants.IO_BUFFER_SIZE);
output = new BufferedWriter(new OutputStreamWriter(out, streamCharset)); output = new BufferedWriter(new OutputStreamWriter(out, streamCharset));
} catch (SQLException e) { } catch (SQLException e) {
close(); close();
...@@ -250,7 +251,6 @@ public class Csv implements SimpleRowSource { ...@@ -250,7 +251,6 @@ public class Csv implements SimpleRowSource {
if (escapeCharacter != 0) { if (escapeCharacter != 0) {
if (fieldDelimiter != 0) { if (fieldDelimiter != 0) {
output.write(fieldDelimiter); output.write(fieldDelimiter);
} }
output.write(escape(s)); output.write(escape(s));
if (fieldDelimiter != 0) { if (fieldDelimiter != 0) {
...@@ -290,14 +290,14 @@ public class Csv implements SimpleRowSource { ...@@ -290,14 +290,14 @@ public class Csv implements SimpleRowSource {
if (input == null) { if (input == null) {
try { try {
InputStream in = FileUtils.openFileInputStream(fileName); InputStream in = FileUtils.openFileInputStream(fileName);
in = new BufferedInputStream(in, bufferSize); in = new BufferedInputStream(in, Constants.IO_BUFFER_SIZE);
input = new InputStreamReader(in, streamCharset); input = new InputStreamReader(in, streamCharset);
input = new BufferedReader(input);
} catch (IOException e) { } catch (IOException e) {
close(); close();
throw e; throw e;
} }
} }
inputBuffer = new char[Constants.IO_BUFFER_SIZE * 2];
if (columnNames == null) { if (columnNames == null) {
readHeader(); readHeader();
} }
...@@ -317,132 +317,149 @@ public class Csv implements SimpleRowSource { ...@@ -317,132 +317,149 @@ public class Csv implements SimpleRowSource {
} }
} else { } else {
list.add(v); list.add(v);
if (endOfLine) {
break;
}
} }
} }
columnNames = new String[list.size()]; columnNames = new String[list.size()];
list.toArray(columnNames); list.toArray(columnNames);
} }
private void pushBack(int ch) { private void pushBack() {
back = ch; inputBufferPos--;
} }
private int readChar() throws IOException { private int readChar() throws IOException {
int ch = back; if (inputBufferPos >= inputBufferEnd) {
if (ch != -1) { return readBuffer();
back = -1; }
return ch; return inputBuffer[inputBufferPos++];
} else if (endOfFile) { }
private int readBuffer() throws IOException {
if (endOfFile) {
return -1; return -1;
} }
ch = input.read(); int keep;
if (ch < 0) { if (inputBufferStart >= 0) {
keep = inputBufferPos - inputBufferStart;
if (keep > 0) {
char[] src = inputBuffer;
if (keep + Constants.IO_BUFFER_SIZE > src.length) {
inputBuffer = new char[src.length * 2];
}
System.arraycopy(src, inputBufferStart, inputBuffer, 0, keep);
}
inputBufferStart = 0;
} else {
keep = 0;
}
inputBufferPos = keep;
int len = input.read(inputBuffer, keep, Constants.IO_BUFFER_SIZE);
if (len == -1) {
// ensure bufferPos > bufferEnd
// even after pushBack
inputBufferEnd = -1024;
endOfFile = true; endOfFile = true;
close(); // ensure the right number of characters are read
// in case the input buffer is still used
inputBufferPos++;
return -1;
} }
return ch; inputBufferEnd = keep + len;
return inputBuffer[inputBufferPos++];
} }
private String readValue() throws IOException { private String readValue() throws IOException {
endOfLine = false; endOfLine = false;
String value = null; inputBufferStart = inputBufferPos;
outer:
while (true) { while (true) {
int ch = readChar(); int ch = readChar();
if (ch < 0 || ch == '\r' || ch == '\n') { if (ch == fieldDelimiter) {
endOfLine = true;
break;
} else if (ch == fieldSeparatorRead) {
// null
break;
} else if (ch <= ' ') {
// ignore spaces
continue;
} else if (ch == fieldDelimiter) {
// delimited value // delimited value
StringBuilder buff = new StringBuilder();
boolean containsEscape = false; boolean containsEscape = false;
inputBufferStart = inputBufferPos;
int sep;
while (true) { while (true) {
ch = readChar(); ch = readChar();
if (ch < 0) { if (ch == fieldDelimiter) {
value = buff.toString();
break outer;
} else if (ch == fieldDelimiter) {
ch = readChar(); ch = readChar();
if (ch == fieldDelimiter) { if (ch != fieldDelimiter) {
buff.append((char) ch); sep = 2;
} else {
pushBack(ch);
break; break;
} }
containsEscape = true;
} else if (ch == escapeCharacter) { } else if (ch == escapeCharacter) {
buff.append((char) ch);
ch = readChar(); ch = readChar();
if (ch < 0) { if (ch < 0) {
sep = 1;
break; break;
} }
containsEscape = true; containsEscape = true;
buff.append((char) ch); } else if (ch < 0) {
} else { sep = 1;
buff.append((char) ch); break;
} }
} }
value = buff.toString(); String s = new String(inputBuffer, inputBufferStart, inputBufferPos - inputBufferStart - sep);
if (containsEscape) { if (containsEscape) {
value = unEscape(value); s = unEscape(s);
} }
inputBufferStart = -1;
while (true) { while (true) {
ch = readChar(); if (ch == fieldSeparatorRead) {
if (ch < 0) {
break; break;
} else if (ch == fieldSeparatorRead) { } else if (ch == '\n' || ch < 0 || ch == '\r') {
endOfLine = true;
break; break;
} else if (ch == ' ' || ch == '\t') { } else if (ch == ' ' || ch == '\t') {
// ignore // ignore
} else if (ch == '\r' || ch == '\n') {
pushBack(ch);
endOfLine = true;
break;
} else { } else {
pushBack(ch); pushBack();
break; break;
} }
ch = readChar();
} }
break; return s;
} else if (ch == '\n' || ch < 0 || ch == '\r') {
endOfLine = true;
return null;
} else if (ch == fieldSeparatorRead) {
// null
return null;
} else if (ch <= ' ') {
// ignore spaces
continue;
} else if (ch == commentLineStart) { } else if (ch == commentLineStart) {
// comment until end of line // comment until end of line
inputBufferStart = -1;
while (true) { while (true) {
ch = readChar(); ch = readChar();
if (ch < 0 || ch == '\r' || ch == '\n') { if (ch == '\n' || ch < 0 || ch == '\r') {
break; break;
} }
} }
endOfLine = true; endOfLine = true;
break; return null;
} else { } else {
// un-delimited value // un-delimited value
StringBuilder buff = new StringBuilder();
buff.append((char) ch);
while (true) { while (true) {
ch = readChar(); ch = readChar();
if (ch == fieldSeparatorRead) { if (ch == fieldSeparatorRead) {
break; break;
} else if (ch == '\r' || ch == '\n') { } else if (ch == '\n' || ch < 0 || ch == '\r') {
pushBack(ch);
endOfLine = true; endOfLine = true;
break; break;
} else if (ch < 0) {
break;
} }
buff.append((char) ch);
} }
String s = new String(inputBuffer, inputBufferStart, inputBufferPos - inputBufferStart - 1);
inputBufferStart = -1;
// check un-delimited value for nullString // check un-delimited value for nullString
value = readNull(buff.toString().trim()); return readNull(s.trim());
break;
} }
} }
// save memory
return StringCache.get(value);
} }
private String readNull(String s) { private String readNull(String s) {
...@@ -456,7 +473,10 @@ public class Csv implements SimpleRowSource { ...@@ -456,7 +473,10 @@ public class Csv implements SimpleRowSource {
while (true) { while (true) {
int idx = s.indexOf(escapeCharacter, start); int idx = s.indexOf(escapeCharacter, start);
if (idx < 0) { if (idx < 0) {
break; idx = s.indexOf(fieldDelimiter, start);
if (idx < 0) {
break;
}
} }
if (chars == null) { if (chars == null) {
chars = s.toCharArray(); chars = s.toCharArray();
...@@ -486,11 +506,11 @@ public class Csv implements SimpleRowSource { ...@@ -486,11 +506,11 @@ public class Csv implements SimpleRowSource {
while (true) { while (true) {
String v = readValue(); String v = readValue();
if (v == null) { if (v == null) {
if (endOfFile && i == 0) {
return null;
}
if (endOfLine) { if (endOfLine) {
if (i == 0) { if (i == 0) {
if (endOfFile) {
return null;
}
// empty line // empty line
continue; continue;
} }
...@@ -500,6 +520,9 @@ public class Csv implements SimpleRowSource { ...@@ -500,6 +520,9 @@ public class Csv implements SimpleRowSource {
if (i < row.length) { if (i < row.length) {
row[i++] = v; row[i++] = v;
} }
if (endOfLine) {
break;
}
} }
} catch (IOException e) { } catch (IOException e) {
throw convertException("IOException reading from " + fileName, e); throw convertException("IOException reading from " + fileName, e);
......
h2/src/main/org/h2/tools/Recover.java
浏览文件 @ eff9d795
...@@ -732,7 +732,7 @@ public class Recover extends Tool implements DataHandler { ...@@ -732,7 +732,7 @@ public class Recover extends Tool implements DataHandler {
} catch (Exception e) { } catch (Exception e) {
writeError(writer, e); writeError(writer, e);
} }
DataPage s = DataPage.create(this, 128); Data s = Data.create(this, 128);
store.seek(0); store.seek(0);
store.readFully(s.getBytes(), 0, 128); store.readFully(s.getBytes(), 0, 128);
s.setPos(48); s.setPos(48);
...@@ -747,7 +747,7 @@ public class Recover extends Tool implements DataHandler { ...@@ -747,7 +747,7 @@ public class Recover extends Tool implements DataHandler {
writer.println("-- ERROR: page size; using " + pageSize); writer.println("-- ERROR: page size; using " + pageSize);
} }
int pageCount = (int) (length / pageSize); int pageCount = (int) (length / pageSize);
s = DataPage.create(this, pageSize); s = Data.create(this, pageSize);
int logFirstTrunkPage = 0, logFirstDataPage = 0; int logFirstTrunkPage = 0, logFirstDataPage = 0;
for (int i = 1;; i++) { for (int i = 1;; i++) {
if (i == 3) { if (i == 3) {
...@@ -778,10 +778,10 @@ public class Recover extends Tool implements DataHandler { ...@@ -778,10 +778,10 @@ public class Recover extends Tool implements DataHandler {
writer.println("-- firstTrunkPage: " + logFirstTrunkPage + writer.println("-- firstTrunkPage: " + logFirstTrunkPage +
" firstDataPage: " + logFirstDataPage); " firstDataPage: " + logFirstDataPage);
s = DataPage.create(this, pageSize); s = Data.create(this, pageSize);
int free = 0; int free = 0;
for (long page = 3; page < pageCount; page++) { for (long page = 3; page < pageCount; page++) {
s = DataPage.create(this, pageSize); s = Data.create(this, pageSize);
store.seek(page * pageSize); store.seek(page * pageSize);
store.readFully(s.getBytes(), 0, pageSize); store.readFully(s.getBytes(), 0, pageSize);
int parentPageId = s.readInt(); int parentPageId = s.readInt();
...@@ -814,7 +814,7 @@ public class Recover extends Tool implements DataHandler { ...@@ -814,7 +814,7 @@ public class Recover extends Tool implements DataHandler {
break; break;
} }
case Page.TYPE_BTREE_NODE: case Page.TYPE_BTREE_NODE:
writer.println("-- page " + page + ": btree node" + (last ? "(last)" : "")); writer.println("-- page " + page + ": b-tree node" + (last ? "(last)" : ""));
if (trace) { if (trace) {
dumpPageBtreeNode(writer, s, !last); dumpPageBtreeNode(writer, s, !last);
} }
...@@ -822,7 +822,7 @@ public class Recover extends Tool implements DataHandler { ...@@ -822,7 +822,7 @@ public class Recover extends Tool implements DataHandler {
case Page.TYPE_BTREE_LEAF: { case Page.TYPE_BTREE_LEAF: {
setStorage(s.readInt()); setStorage(s.readInt());
int entries = s.readShortInt(); int entries = s.readShortInt();
writer.println("-- page " + page + ": btree leaf " + (last ? "(last)" : "") + " table: " + storageId + " entries: " + entries); writer.println("-- page " + page + ": b-tree leaf " + (last ? "(last)" : "") + " table: " + storageId + " entries: " + entries);
if (trace) { if (trace) {
dumpPageBtreeLeaf(writer, s, entries, !last); dumpPageBtreeLeaf(writer, s, entries, !last);
} }
...@@ -1030,16 +1030,21 @@ public class Recover extends Tool implements DataHandler { ...@@ -1030,16 +1030,21 @@ public class Recover extends Tool implements DataHandler {
} }
} }
private void dumpPageBtreeNode(PrintWriter writer, DataPage s, boolean positionOnly) { private void dumpPageBtreeNode(PrintWriter writer, Data s, boolean positionOnly) {
int entryCount = s.readShortInt(); int entryCount = s.readShortInt();
int rowCount = s.readInt(); int rowCount = s.readInt();
int[] children = new int[entryCount + 1]; int[] children = new int[entryCount + 1];
int[] offsets = new int[entryCount]; int[] offsets = new int[entryCount];
children[entryCount] = s.readInt(); children[entryCount] = s.readInt();
int empty = Integer.MAX_VALUE;
for (int i = 0; i < entryCount; i++) { for (int i = 0; i < entryCount; i++) {
children[i] = s.readInt(); children[i] = s.readInt();
offsets[i] = s.readInt(); int off = s.readInt();
empty = Math.min(off, empty);
offsets[i] = off;
} }
empty = empty - s.length();
writer.println("-- empty: " + empty);
for (int i = 0; i < entryCount; i++) { for (int i = 0; i < entryCount; i++) {
int off = offsets[i]; int off = offsets[i];
s.setPos(off); s.setPos(off);
...@@ -1060,7 +1065,7 @@ public class Recover extends Tool implements DataHandler { ...@@ -1060,7 +1065,7 @@ public class Recover extends Tool implements DataHandler {
writer.println("-- [" + entryCount + "] child: " + children[entryCount] + " rowCount: " + rowCount); writer.println("-- [" + entryCount + "] child: " + children[entryCount] + " rowCount: " + rowCount);
} }
private int dumpPageFreeList(PrintWriter writer, DataPage s, int pageSize, long pageId, long pageCount) { private int dumpPageFreeList(PrintWriter writer, Data s, int pageSize, long pageId, long pageCount) {
int pagesAddressed = PageFreeList.getPagesAddressed(pageSize); int pagesAddressed = PageFreeList.getPagesAddressed(pageSize);
BitField used = new BitField(); BitField used = new BitField();
for (int i = 0; i < pagesAddressed; i += 8) { for (int i = 0; i < pagesAddressed; i += 8) {
...@@ -1087,11 +1092,16 @@ public class Recover extends Tool implements DataHandler { ...@@ -1087,11 +1092,16 @@ public class Recover extends Tool implements DataHandler {
return free; return free;
} }
private void dumpPageBtreeLeaf(PrintWriter writer, DataPage s, int entryCount, boolean positionOnly) { private void dumpPageBtreeLeaf(PrintWriter writer, Data s, int entryCount, boolean positionOnly) {
int[] offsets = new int[entryCount]; int[] offsets = new int[entryCount];
int empty = Integer.MAX_VALUE;
for (int i = 0; i < entryCount; i++) { for (int i = 0; i < entryCount; i++) {
offsets[i] = s.readShortInt(); int off = s.readShortInt();
empty = Math.min(off, empty);
offsets[i] = off;
} }
empty = empty - s.length();
writer.println("-- empty: " + empty);
for (int i = 0; i < entryCount; i++) { for (int i = 0; i < entryCount; i++) {
int off = offsets[i]; int off = offsets[i];
s.setPos(off); s.setPos(off);
...@@ -1111,17 +1121,22 @@ public class Recover extends Tool implements DataHandler { ...@@ -1111,17 +1121,22 @@ public class Recover extends Tool implements DataHandler {
} }
} }
private void dumpPageDataLeaf(FileStore store, int pageSize, PrintWriter writer, DataPage s, boolean last, long pageId, int entryCount) throws SQLException { private void dumpPageDataLeaf(FileStore store, int pageSize, PrintWriter writer, Data s, boolean last, long pageId, int entryCount) throws SQLException {
int[] keys = new int[entryCount]; int[] keys = new int[entryCount];
int[] offsets = new int[entryCount]; int[] offsets = new int[entryCount];
long next = 0; long next = 0;
if (!last) { if (!last) {
next = s.readInt(); next = s.readInt();
} }
int empty = Integer.MAX_VALUE;
for (int i = 0; i < entryCount; i++) { for (int i = 0; i < entryCount; i++) {
keys[i] = s.readInt(); keys[i] = s.readInt();
offsets[i] = s.readShortInt(); int off = s.readShortInt();
empty = Math.min(off, empty);
offsets[i] = off;
} }
empty = empty - s.length();
writer.println("-- empty: " + empty);
if (!last) { if (!last) {
DataPage s2 = DataPage.create(this, pageSize); DataPage s2 = DataPage.create(this, pageSize);
s.setPos(pageSize); s.setPos(pageSize);
......
h2/src/test/org/h2/test/db/TestCsv.java
浏览文件 @ eff9d795
...@@ -92,18 +92,18 @@ public class TestCsv extends TestBase { ...@@ -92,18 +92,18 @@ public class TestCsv extends TestBase {
csv.setNullString("\\N"); csv.setNullString("\\N");
ResultSet rs = csv.read(f.getPath(), null, "UTF8"); ResultSet rs = csv.read(f.getPath(), null, "UTF8");
ResultSetMetaData meta = rs.getMetaData(); ResultSetMetaData meta = rs.getMetaData();
assertEquals(meta.getColumnCount(), 4); assertEquals(4, meta.getColumnCount());
assertEquals(meta.getColumnLabel(1), "A"); assertEquals("A", meta.getColumnLabel(1));
assertEquals(meta.getColumnLabel(2), "B"); assertEquals("B", meta.getColumnLabel(2));
assertEquals(meta.getColumnLabel(3), "C"); assertEquals("C", meta.getColumnLabel(3));
assertEquals(meta.getColumnLabel(4), "D"); assertEquals("D", meta.getColumnLabel(4));
assertTrue(rs.next()); assertTrue(rs.next());
assertEquals(rs.getString(1), null); assertEquals(null, rs.getString(1));
assertEquals(rs.getString(2), ""); assertEquals("", rs.getString(2));
// null is never quoted // null is never quoted
assertEquals(rs.getString(3), "\\N"); assertEquals("\\N", rs.getString(3));
// an empty string is always parsed as null // an empty string is always parsed as null
assertEquals(rs.getString(4), null); assertEquals(null, rs.getString(4));
assertFalse(rs.next()); assertFalse(rs.next());
Connection conn = getConnection("csv"); Connection conn = getConnection("csv");
...@@ -177,12 +177,12 @@ public class TestCsv extends TestBase { ...@@ -177,12 +177,12 @@ public class TestCsv extends TestBase {
assertEquals("ID|NAME 1|Hello", text); assertEquals("ID|NAME 1|Hello", text);
ResultSet rs = stat.executeQuery("select * from csvread('" + baseDir + "/test.csv', null, null, '|', '')"); ResultSet rs = stat.executeQuery("select * from csvread('" + baseDir + "/test.csv', null, null, '|', '')");
ResultSetMetaData meta = rs.getMetaData(); ResultSetMetaData meta = rs.getMetaData();
assertEquals(meta.getColumnCount(), 2); assertEquals(2, meta.getColumnCount());
assertEquals(meta.getColumnLabel(1), "ID"); assertEquals("ID", meta.getColumnLabel(1));
assertEquals(meta.getColumnLabel(2), "NAME"); assertEquals("NAME", meta.getColumnLabel(2));
assertTrue(rs.next()); assertTrue(rs.next());
assertEquals(rs.getString(1), "1"); assertEquals("1", rs.getString(1));
assertEquals(rs.getString(2), "Hello"); assertEquals("Hello", rs.getString(2));
assertFalse(rs.next()); assertFalse(rs.next());
conn.close(); conn.close();
FileUtils.delete(baseDir + "/test.csv"); FileUtils.delete(baseDir + "/test.csv");
...@@ -198,22 +198,22 @@ public class TestCsv extends TestBase { ...@@ -198,22 +198,22 @@ public class TestCsv extends TestBase {
Statement stat = conn.createStatement(); Statement stat = conn.createStatement();
ResultSet rs = stat.executeQuery("select * from csvread('" + baseDir + "/test.csv', null, null, ';', '''', '\\')"); ResultSet rs = stat.executeQuery("select * from csvread('" + baseDir + "/test.csv', null, null, ';', '''', '\\')");
ResultSetMetaData meta = rs.getMetaData(); ResultSetMetaData meta = rs.getMetaData();
assertEquals(meta.getColumnCount(), 2); assertEquals(2, meta.getColumnCount());
assertEquals(meta.getColumnLabel(1), "A"); assertEquals("A", meta.getColumnLabel(1));
assertEquals(meta.getColumnLabel(2), "B"); assertEquals("B", meta.getColumnLabel(2));
assertTrue(rs.next()); assertTrue(rs.next());
assertEquals(rs.getString(1), "It's nice"); assertEquals("It's nice", rs.getString(1));
assertEquals(rs.getString(2), "\nHello*\n"); assertEquals("\nHello*\n", rs.getString(2));
assertFalse(rs.next()); assertFalse(rs.next());
stat.execute("call csvwrite('" + baseDir + "/test2.csv', 'select * from csvread(''" + baseDir + "/test.csv'', null, null, '';'', '''''''', ''\\'')', null, '+', '*', '#')"); stat.execute("call csvwrite('" + baseDir + "/test2.csv', 'select * from csvread(''" + baseDir + "/test.csv'', null, null, '';'', '''''''', ''\\'')', null, '+', '*', '#')");
rs = stat.executeQuery("select * from csvread('" + baseDir + "/test2.csv', null, null, '+', '*', '#')"); rs = stat.executeQuery("select * from csvread('" + baseDir + "/test2.csv', null, null, '+', '*', '#')");
meta = rs.getMetaData(); meta = rs.getMetaData();
assertEquals(meta.getColumnCount(), 2); assertEquals(2, meta.getColumnCount());
assertEquals(meta.getColumnLabel(1), "A"); assertEquals("A", meta.getColumnLabel(1));
assertEquals(meta.getColumnLabel(2), "B"); assertEquals("B", meta.getColumnLabel(2));
assertTrue(rs.next()); assertTrue(rs.next());
assertEquals(rs.getString(1), "It's nice"); assertEquals("It's nice", rs.getString(1));
assertEquals(rs.getString(2), "\nHello*\n"); assertEquals("\nHello*\n", rs.getString(2));
assertFalse(rs.next()); assertFalse(rs.next());
conn.close(); conn.close();
FileUtils.delete(baseDir + "/test.csv"); FileUtils.delete(baseDir + "/test.csv");
...@@ -227,8 +227,8 @@ public class TestCsv extends TestBase { ...@@ -227,8 +227,8 @@ public class TestCsv extends TestBase {
stat.execute("call csvwrite('" + baseDir + "/test.csv', 'select 1 id, ''Hello'' name', 'utf-8', '|')"); stat.execute("call csvwrite('" + baseDir + "/test.csv', 'select 1 id, ''Hello'' name', 'utf-8', '|')");
ResultSet rs = stat.executeQuery("select * from csvread('" + baseDir + "/test.csv', null, 'utf-8', '|')"); ResultSet rs = stat.executeQuery("select * from csvread('" + baseDir + "/test.csv', null, 'utf-8', '|')");
assertTrue(rs.next()); assertTrue(rs.next());
assertEquals(rs.getInt(1), 1); assertEquals(1, rs.getInt(1));
assertEquals(rs.getString(2), "Hello"); assertEquals("Hello", rs.getString(2));
assertFalse(rs.next()); assertFalse(rs.next());
new File(baseDir + "/test.csv").delete(); new File(baseDir + "/test.csv").delete();
...@@ -250,12 +250,12 @@ public class TestCsv extends TestBase { ...@@ -250,12 +250,12 @@ public class TestCsv extends TestBase {
stat.execute("call csvwrite('" + baseDir + "/test.csv', 'select 1 id, ''Hello'' name')"); stat.execute("call csvwrite('" + baseDir + "/test.csv', 'select 1 id, ''Hello'' name')");
ResultSet rs = stat.executeQuery("select name from csvread('" + baseDir + "/test.csv')"); ResultSet rs = stat.executeQuery("select name from csvread('" + baseDir + "/test.csv')");
assertTrue(rs.next()); assertTrue(rs.next());
assertEquals(rs.getString(1), "Hello"); assertEquals("Hello", rs.getString(1));
assertFalse(rs.next()); assertFalse(rs.next());
rs = stat.executeQuery("call csvread('" + baseDir + "/test.csv')"); rs = stat.executeQuery("call csvread('" + baseDir + "/test.csv')");
assertTrue(rs.next()); assertTrue(rs.next());
assertEquals(rs.getInt(1), 1); assertEquals(1, rs.getInt(1));
assertEquals(rs.getString(2), "Hello"); assertEquals("Hello", rs.getString(2));
assertFalse(rs.next()); assertFalse(rs.next());
new File(baseDir + "/test.csv").delete(); new File(baseDir + "/test.csv").delete();
conn.close(); conn.close();
...@@ -269,31 +269,31 @@ public class TestCsv extends TestBase { ...@@ -269,31 +269,31 @@ public class TestCsv extends TestBase {
file.close(); file.close();
ResultSet rs = Csv.getInstance().read(baseDir + "/test.csv", null, "UTF8"); ResultSet rs = Csv.getInstance().read(baseDir + "/test.csv", null, "UTF8");
ResultSetMetaData meta = rs.getMetaData(); ResultSetMetaData meta = rs.getMetaData();
assertEquals(meta.getColumnCount(), 4); assertEquals(4, meta.getColumnCount());
assertEquals(meta.getColumnLabel(1), "a"); assertEquals("a", meta.getColumnLabel(1));
assertEquals(meta.getColumnLabel(2), "b"); assertEquals("b", meta.getColumnLabel(2));
assertEquals(meta.getColumnLabel(3), "c"); assertEquals("c", meta.getColumnLabel(3));
assertEquals(meta.getColumnLabel(4), "d"); assertEquals("d", meta.getColumnLabel(4));
assertTrue(rs.next()); assertTrue(rs.next());
assertEquals(rs.getString(1), "201"); assertEquals("201", rs.getString(1));
assertEquals(rs.getString(2), "-2"); assertEquals("-2", rs.getString(2));
assertEquals(rs.getString(3), "0"); assertEquals("0", rs.getString(3));
assertEquals(rs.getString(4), "18"); assertEquals("18", rs.getString(4));
assertTrue(rs.next()); assertTrue(rs.next());
assertEquals(rs.getString(1), null); assertEquals(null, rs.getString(1));
assertEquals(rs.getString(2), "abc\""); assertEquals("abc\"", rs.getString(2));
assertEquals(rs.getString(3), null); assertEquals(null, rs.getString(3));
assertEquals(rs.getString(4), ""); assertEquals("", rs.getString(4));
assertTrue(rs.next()); assertTrue(rs.next());
assertEquals(rs.getString(1), "1"); assertEquals("1", rs.getString(1));
assertEquals(rs.getString(2), "2"); assertEquals("2", rs.getString(2));
assertEquals(rs.getString(3), "3"); assertEquals("3", rs.getString(3));
assertEquals(rs.getString(4), "4"); assertEquals("4", rs.getString(4));
assertTrue(rs.next()); assertTrue(rs.next());
assertEquals(rs.getString(1), "5"); assertEquals("5", rs.getString(1));
assertEquals(rs.getString(2), "6"); assertEquals("6", rs.getString(2));
assertEquals(rs.getString(3), "7"); assertEquals("7", rs.getString(3));
assertEquals(rs.getString(4), "8"); assertEquals("8", rs.getString(4));
assertFalse(rs.next()); assertFalse(rs.next());
// a,b,c,d // a,b,c,d
...@@ -324,8 +324,8 @@ public class TestCsv extends TestBase { ...@@ -324,8 +324,8 @@ public class TestCsv extends TestBase {
assertEquals(2, meta.getColumnCount()); assertEquals(2, meta.getColumnCount());
for (int i = 0; i < len; i++) { for (int i = 0; i < len; i++) {
rs.next(); rs.next();
assertEquals(rs.getString("ID"), "" + (i + 1)); assertEquals("" + (i + 1), rs.getString("ID"));
assertEquals(rs.getString("NAME"), "Ruebezahl"); assertEquals("Ruebezahl", rs.getString("NAME"));
} }
assertFalse(rs.next()); assertFalse(rs.next());
rs.close(); rs.close();
......
Markdown 格式
0% 或
您添加了 0 人 到此讨论。请谨慎行事。
请先完成此评论的编辑！
请 注册 或者 后发表评论