Allow writing to linked tables in readonly databases

I wrote the code, it belongs to Docware GmbH, and Docware GmbH is contributing it to H2 for distribution.
Multiple-licensed under the H2 License, version 1.0, and under the
Eclipse Public License, version 1.0 (http://h2database.com/html/license.html).

h2/src/docsrc/html/changelog.html

@@ -22,6 +22,7 @@ Change Log
 </li><li>Bugfixes in the page store.
 </li><li>Possibility to set a vendor id in Constants.java, so that unofficial builds are distinguishable
     from official releases.
+</li><li>Allow writing to linked tables in readonly databases.
 </li></ul>
 
 <h2>Version 1.1.119 (2009-09-26)</h2>

h2/src/main/org/h2/engine/User.java

@@ -91,7 +91,7 @@ public class User extends RightOwner {
      */
     public void checkRight(Table table, int rightMask) throws SQLException {
         if (rightMask != Right.SELECT && !systemUser) {
-            database.checkWritingAllowed();
+            table.checkWritingAllowed();
         }
         if (admin) {
             return;

h2/src/main/org/h2/table/Table.java

@@ -937,6 +937,15 @@ public abstract class Table extends SchemaObjectBase {
         return compareMode;
     }
 
+    /**
+     * Tests if the table can be written. Usually, this depends on the
+     * database.checkWritingAllowed method, but some tables (eg. TableLink)
+     * overwrite this default behaviour.
+     */
+    public void checkWritingAllowed() throws SQLException {
+        database.checkWritingAllowed();
+    }
+
     /**
      * Get or generate a default value for the given column.
      *

h2/src/main/org/h2/table/TableLink.java

@@ -543,6 +543,13 @@ public class TableLink extends Table {
         return false;
     }
 
+    /**
+     * Linked tables don't know if they are readonly. This overwrites
+     * the default handling.
+     */
+    public void checkWritingAllowed() throws SQLException {
+    }
+
     /**
      * Convert the values if required. Default values are not set (kept as
      * null).

h2/src/test/org/h2/test/db/TestLinkedTable.java

@@ -6,6 +6,7 @@
  */
 package org.h2.test.db;
 
+import java.io.File;
 import java.math.BigDecimal;
 import java.sql.Connection;
 import java.sql.DriverManager;
@@ -47,6 +48,7 @@ public class TestLinkedTable extends TestBase {
         testLinkTable();
         testLinkTwoTables();
         testCachingResults();
+        testLinkedTableInReadOnlyDb();
 
         deleteDb("linkedTable");
     }
@@ -582,4 +584,46 @@ public class TestLinkedTable extends TestBase {
         }
         assertEquals(expected, counter);
     }
+
+    private void testLinkedTableInReadOnlyDb() throws SQLException {
+        if (config.memory || config.networked) {
+            return;
+        }
+
+        deleteDb("testLinkedTableInReadOnlyDb");
+        org.h2.Driver.load();
+
+        Connection memConn = DriverManager.getConnection("jdbc:h2:mem:one", "sa", "sa");
+        Statement memStat = memConn.createStatement();
+        memStat.execute("CREATE TABLE TEST(ID VARCHAR)");
+
+        String url1 = getURL("testLinkedTableInReadOnlyDb", true);
+        Connection conn = DriverManager.getConnection(url1, "sa1", "abc abc");
+        Statement stat = conn.createStatement();
+        stat.execute("CREATE TABLE TEST(ID INT PRIMARY KEY)");
+        conn.close();
+
+        File[] files = new File(baseDir).listFiles();
+        for (File file : files) {
+            if (file.getName().startsWith("testLinkedTableInReadOnlyDb")) {
+                boolean isReadOnly = file.setReadOnly();
+                if (!isReadOnly) {
+                    fail("File " + file.getAbsolutePath() + " is not read only. Can't test it");
+                }
+            }
+        }
+
+        // Now it's read only
+        conn = DriverManager.getConnection(url1, "sa1", "abc abc");
+        stat = conn.createStatement();
+        stat.execute("CREATE LOCAL TEMPORARY LINKED TABLE T(NULL, 'jdbc:h2:mem:one', 'sa', 'sa', 'TEST')");
+        // This is valid because it's a linked table
+        stat.execute("INSERT INTO T VALUES('abc')");
+
+        conn.close();
+        memConn.close();
+
+        deleteDb("testLinkedTableInReadOnlyDb");
+    }
+
 }

h2/src/tools/org/h2/build/doc/dictionary.txt

@@ -613,4 +613,4 @@ modern slight boost characteristics significantly gae vfs centrally ten
 approach risky getters suxxess gmb delegate delegating delegates collisions
 linkage superfluous disallow scoop moebius inputs copilot dmoebius leod jenkov
 jakob poker docware peter unstable measurable scramble reissued recreation
-scrambling distinguish official unofficial distinguishable
+scrambling distinguish official unofficial distinguishable overwrites
\ No newline at end of file