1. 21 2月, 2011 5 次提交
    • Thomas Mueller's avatar
      Build: download jar file using Maven if possible · 806e90b9
      Thomas Mueller 提交于
      806e90b9
    • Thomas Mueller's avatar
      Cleanup: · 5cdfa58c
      Thomas Mueller 提交于
      - Source code formatting (Eclipse will find this)
      - Missing Javadoc class comment
      - The test didn't compare myString (Eclipse will find this)
      - Missing space around '=' (Checkstyle will find this)
      5cdfa58c
    • Thomas Mueller's avatar
      Cleanup: · 164f02af
      Thomas Mueller 提交于
      - Javadoc comment for the class was missing (./build.sh should find this)
      - Make fields private where possible
      - Do not comment source code (// EventLogger.activateConsoleLogger();). Remove it.
      - Simplify error code assertions
      164f02af
    • Thomas Mueller's avatar
      Cleanup: · 82ecbf33
      Thomas Mueller 提交于
      - Typos in Javadocs (./build.sh spellcheck finds this)
      - Use private fields where possible
      - Fix Javadoc with something that isn't a sentence
      - Fix Javadoc without an actual comment
      - The workaround 'clazz' instead of 'class' is not needed for 'dateClazz'
      - Javadoc for parameters is inconsistent / incorrect
      - Javadoc: undocumented return
      - Javadoc comments are usually lowercase except for sentences
      82ecbf33
    • Thomas Mueller's avatar
      Cleanup: · c6e9d93c
      Thomas Mueller 提交于
      - Fix bug about using an (unordered) set for index and primary key columns
      - Non-private fields first (Checkstyle reports this)
      - Comments are on a separate line (Checkstyle)
      - Space before and after "=" (Eclipse reports this)
      - Comment, specially comment fragements, are lowercase
      c6e9d93c
  2. 20 2月, 2011 5 次提交
    • Thomas Mueller's avatar
      Cleanup: · e857a250
      Thomas Mueller 提交于
      - Let it compile with JDK 5
      e857a250
    • Thomas Mueller's avatar
      Cleanup: · dd7cdf0d
      Thomas Mueller 提交于
      - Make fields and methods private where possible
      - Add missing Javadocs
      - Remove @throws Javadocs (all other languages don't have throws, and it doesn't help much documenting them)
      - Use camel case for metaData
      - Remove initializing to default values (null, 0, false) because that's anyway done automatically
      - Remove @Override to let it compile with JDK 5
      - Mark as 'work in progress'
      dd7cdf0d
    • Thomas Mueller's avatar
      Cleanup: · 4c5b1c44
      Thomas Mueller 提交于
      - Add class level Javadoc documentation (I hope it's somewhat correct)
      - Make fields private if possible
      - Enable the trace option when running in standalone mode
      - Instead of System.out.println(), use trace()
      - Remove 'verbose' flag, use the trace flag instead
      - Remove @Override so it can be compiled with JDK 5 (so that the nightly build works)
      - Use { .. } even for single line blocks - this is the code convention used in H2 (so that insertion of a new line of code anywhere is always "safe")
      4c5b1c44
    • Thomas Mueller's avatar
      Cleanup: · e38a0a80
      Thomas Mueller 提交于
      - Improve Javadoc documentation
      - Javadoc: add missing documentation for <T> (the IDE or checkstyle flags this) 
      - Javadoc: removed trailing whitespace
      - Remove @Override tag because this won't compile with JDK 5
      - Flag that there is something wrong (what if 'y' isn't a Number? anyway instanceof should be avoided)
      e38a0a80
    • Thomas Mueller's avatar
      Cleanup: · 631e7a00
      Thomas Mueller 提交于
      - Improve Javadoc documentation
      - Javadoc: removed unpaired <p>
      - Javadoc: removed shouting (bold, caps "MUST")
      - Javadoc: document parameters
      - Javadoc: no need to write Return in a @return tag
      - Javadoc: make correct sentences, not sentence fragments ('Default Db Upgrader.' is not a sentence)
      - Remove @Override tag because this won't compile with JDK 5
      - Methods in public interfaces don't need to be declared public (Checkstyle detects this, please use Checkstyle as documented)
      631e7a00
  3. 19 2月, 2011 3 次提交
    • Thomas Mueller's avatar
      Cleanup: · b51dab94
      Thomas Mueller 提交于
      - Improve Javadoc documentation
      - Add Javadoc documentation (each class and interface method should be documented)
      - I didn't want to use MessageFormat but I guess that's not an important change
      b51dab94
    • Thomas Mueller's avatar
      Cleanup: · b94fe304
      Thomas Mueller 提交于
      - add missing //## Java 1.5 end ##
      - according to checkstyle final static fields names are all caps
      - remove trailing spaces (please configure the IDE accordingly)
      - add missing space after comma (please configure checkstyle)
      
      Please note that counter++ is counter.getAndIncrement() and not counter.incrementAndGet(). But I guess this doesn't make a difference here.
      b94fe304
    • james.moger@gmail.com's avatar
  4. 18 2月, 2011 8 次提交
  5. 17 2月, 2011 7 次提交
  6. 16 2月, 2011 12 次提交